Differential D17894

Move inline replies to new code and remove DifferentialInlineEditor
ClosedPublic
Actions

Authored by epriestley on May 15 2017, 11:49 PM.

Details

Reviewers

chad

Maniphest Tasks

T12616: Modernize display code for inline comments

Commits

rP41379f39debb: Move inline replies to new code and remove DifferentialInlineEditor

Summary

Ref T12616. This moves "reply" to the new stuff and deletes DifferentialInlineEditor, which no longer does anything.

(This breaks some keyboard shortcuts, but I'll rebase D17859 shortly.)

Test Plan

Replied to inlines; things seemed to work properly.

Diff Detail

Repository

rP Phabricator

Branch

inline12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16963
Build 22674: Run Core Tests
Build 22673: arc lint + arc unit

Event Timeline

epriestley created this revision.May 15 2017, 11:49 PM

Harbormaster completed remote builds in B16963: Diff 43036.May 15 2017, 11:50 PM

epriestley mentioned this in D17859: Move most Differetial keyboard shortcuts into DiffChangesetList.May 15 2017, 11:58 PM

chad accepted this revision.May 16 2017, 12:24 AM

This revision is now accepted and ready to land.May 16 2017, 12:24 AM

Closed by commit rP41379f39debb: Move inline replies to new code and remove DifferentialInlineEditor (authored by epriestley, committed by epriestley). · Explain WhyMay 16 2017, 1:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

75 lines

packages.php

3 lines

src/

infrastructure/

diff/

PhabricatorInlineCommentController.php

13 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangeset.js

12 lines

DiffChangesetList.js

9 lines

DiffInline.js

61 lines

differential/

DifferentialInlineCommentEditor.js

behavior-edit-inline-comments.js

93 lines

Diff 43036

View Options

resources/celerity/map.php

View Options

resources/celerity/packages.php

View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

View Options

webroot/rsrc/js/application/diff/DiffInline.js

View Options

webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js

View Options

webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js

Move inline replies to new code and remove DifferentialInlineEditorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43036

resources/celerity/map.php

resources/celerity/packages.php

src/infrastructure/diff/PhabricatorInlineCommentController.php

webroot/rsrc/js/application/diff/DiffChangeset.js

webroot/rsrc/js/application/diff/DiffChangesetList.js

webroot/rsrc/js/application/diff/DiffInline.js

webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js

webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js

Move inline replies to new code and remove DifferentialInlineEditor
ClosedPublic
Actions

Revision Contents
Changeset List