Page MenuHomePhabricator
Differential D17894

Move inline replies to new code and remove DifferentialInlineEditor
ClosedPublic
Actions

Authored by epriestley on May 15 2017, 11:49 PM.
Tags
None
Referenced Files
F15473360: D17894.id.diff
Sat, Apr 5, 9:11 PM
F15468706: D17894.diff
Fri, Apr 4, 4:46 AM
F15463690: D17894.id43054.diff
Wed, Apr 2, 2:11 AM
F15421687: D17894.id43054.diff
Sat, Mar 22, 1:37 AM
F15421686: D17894.id43036.diff
Sat, Mar 22, 1:37 AM
F15421661: D17894.diff
Sat, Mar 22, 1:33 AM
F15325976: D17894.id43036.diff
Mar 7 2025, 3:07 AM
Unknown Object (File)
Feb 24 2025, 11:43 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12616: Modernize display code for inline comments
Commits
rP41379f39debb: Move inline replies to new code and remove DifferentialInlineEditor
Summary

Ref T12616. This moves "reply" to the new stuff and deletes DifferentialInlineEditor, which no longer does anything.

(This breaks some keyboard shortcuts, but I'll rebase D17859 shortly.)

Test Plan

Replied to inlines; things seemed to work properly.

Diff Detail

Repository
rP Phabricator
Branch
inline12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16963
Build 22674: Run Core Tests
Build 22673: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
75 lines
3 lines
src/
infrastructure/
diff/
13 lines
webroot/
rsrc/
js/
application/
diff/
12 lines
9 lines
61 lines
differential/
93 lines

Diff 43036

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
View Options

webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js

Loading...
Phabricator · Built by Phacility