Page MenuHomePhabricator

Hide inlines one-by-one, instead of in a big group
ClosedPublic

Authored by epriestley on May 9 2017, 9:01 PM.
Tags
None
Referenced Files
F14017879: D17861.diff
Tue, Nov 5, 12:21 AM
Unknown Object (File)
Oct 9 2024, 7:59 AM
Unknown Object (File)
Oct 2 2024, 3:56 AM
Unknown Object (File)
Sep 10 2024, 7:04 AM
Unknown Object (File)
Sep 6 2024, 12:17 AM
Unknown Object (File)
Sep 1 2024, 12:41 AM
Unknown Object (File)
Aug 30 2024, 2:03 AM
Unknown Object (File)
Aug 26 2024, 4:38 AM
Subscribers
None

Details

Summary

Ref T12616. Fixes T12153. Currently, when you hide inlines, they hide completely and turn into a little bubble on the previous line.

Instead, collapse them to a single line one-by-one. Narrowly, this fixes T12153.

In the future, I plan to make these changes so this feature makes more sense:

  • Introduce global "hide everything" states (T8909) so you can completely hide stuff if you want, and this represents more of a halfway state between "nuke it" and "view it".
  • Make the actual rendering better, so it says "epriestley: blah blah..." instead of just "..." -- and looks less dumb.

The real goal here is to introduce DiffInline and continue moving stuff from the tangled jungle of a million top-level behaviors to sensible smooth statefulness.

Test Plan
  • Hid and revealed inlines in unified and two-up modes.
  • These look pretty junk for now:

Screen Shot 2017-05-09 at 1.40.25 PM.png (333×925 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Branch
inline7
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php:459XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 16881
Build 22544: Run Core Tests
Build 22543: arc lint + arc unit

Event Timeline

I'll hold this until a future change fixes the rendering (and likely until I find a complete path through the wilderness) since this is sort of borderline-unusable as-is, this was just a reasonable sort of checkpoint.

This revision is now accepted and ready to land.May 9 2017, 11:53 PM
This revision was automatically updated to reflect the committed changes.