Update Legalpad for modular transactions
Details
Details
- Reviewers
epriestley - Commits
- rP705fd11ba173: Update Legalpad to use modular transactions
- New Document (no sign)
- New Document (individual)
- New Document (corp)
- Require Signature - get prompted to sign before I can do anything.
- Edit Documents
- Sign Documents
- Comment on Documents
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- legalpad-xaction (branched from master)
- Lint
Lint Passed Severity Location Code Message Advice src/applications/legalpad/editor/LegalpadDocumentEditor.php:28 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 16799 Build 22421: Run Core Tests Build 22420: arc lint + arc unit
Event Timeline
| src/applications/legalpad/editor/LegalpadDocumentEditor.php | ||
|---|---|---|
| 28 | Set a document you haven't signed to "Require signature to use Phabricator." If the code works, you'll immediately be prompted to sign it. The meaning here is "when a new document is configured to require a signature, invalidate the flag on all existing sessions so users have to sign it even if they were previously logged in with valid sessions". | |
| src/applications/legalpad/storage/LegalpadTransaction.php | ||
| 26–37 | (Might not get called / be unnecessary?) | |
| src/applications/legalpad/xaction/LegalpadDocumentTitleTransaction.php | ||
| 29 | Word "document" probably reads awkwardly; remove? | |