Overall, seems to work ok.
Details
Details
- Reviewers
epriestley - Commits
- rPa06704002445: Update Macro for Modular Transactions
- Add a Macro
- Edit Macro
- Use Macro
- Disable Macro
- Re-enable Macro
- Attach Audio
- Set Audio to loop
- Annoy cats
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- macro-xaction (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16760 Build 22360: Run Core Tests Build 22359: arc lint + arc unit
Event Timeline
| src/applications/macro/editor/PhabricatorMacroEditor.php | ||
|---|---|---|
| 17 | I think you can omit this and that we determine it automatically (which would let you delete the whole method). (Presumably, you can test that by deleting it and seeing if you can still leave comments.) | |
| src/applications/macro/editor/PhabricatorMacroEditor.php | ||
|---|---|---|
| 17 | I think it needs to be modernized, it fataled. | |