Page MenuHomePhabricator
Differential D17729

Remove "behindTransactionPHID" from ConpherenceParticipant
ClosedPublic
Actions

Authored by epriestley on Apr 19 2017, 7:03 PM.
Tags
None
Referenced Files
F15485172: D17729.diff
Wed, Apr 9, 10:19 PM
F15483625: D17729.diff
Wed, Apr 9, 1:31 PM
F15474073: D17729.id42644.diff
Sun, Apr 6, 5:15 AM
F15466679: D17729.id.diff
Thu, Apr 3, 8:14 AM
F15446531: D17729.id.diff
Thu, Mar 27, 7:28 PM
F15440415: D17729.id42654.diff
Wed, Mar 26, 12:46 PM
F15407297: D17729.id42654.diff
Tue, Mar 18, 4:45 PM
F15385469: D17729.id42654.diff
Mar 14 2025, 10:41 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rPc96e17f5ea42: Remove "behindTransactionPHID" from ConpherenceParticipant
Summary

Pathway to D17685. Nothing reads this field and it has no use or value.

Test Plan
  • Ran migration.
  • Grepped for behindTransactionPHID.

Diff Detail

Repository
rP Phabricator
Branch
status1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16579
Build 22102: Run Core Tests
Build 22101: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 19 2017, 7:03 PM
Harbormaster completed remote builds in B16579: Diff 42644.Apr 19 2017, 7:03 PM
Harbormaster completed remote builds in B16579: Diff 42644.
chad accepted this revision.Apr 19 2017, 7:14 PM
This revision is now accepted and ready to land.Apr 19 2017, 7:14 PM
Closed by commit rPc96e17f5ea42: Remove "behindTransactionPHID" from ConpherenceParticipant (authored by epriestley, committed by epriestley). · Explain WhyApr 19 2017, 8:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
applications/
conpherence/
editor/
7 lines
storage/
2 lines

Diff 42644

View Options

resources/sql/autopatches/20170419.thread.01.behind.sql

Loading...
View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceParticipant.php

Loading...
Phabricator · Built by Phacility