Don't show tag when no topic is set
ClosedPublic
Actions

Authored by chad on Apr 17 2017, 11:12 PM.

Tags

None

Referenced Files

	F13260735: D17715.diff
	Mon, May 27, 12:19 AM

	F13243128: D17715.diff
	Thu, May 23, 3:23 AM

	F13227834: D17715.id.diff
	Mon, May 20, 5:15 AM

	F13221499: D17715.diff
	Sun, May 19, 2:49 AM

	F13203890: D17715.diff
	Wed, May 15, 12:11 AM

	F13193880: D17715.id42605.diff
	Sun, May 12, 6:52 PM

	F13186521: D17715.diff
	Sat, May 11, 3:41 AM

	F13184519: D17715.id.diff
	Fri, May 10, 7:50 PM

View All 62 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPc98be54bf4e6: Don't show tag when no topic is set

Summary

Check the strlen of topic before adding a tag to the header in Conpherence.

Test Plan

Remove a topic, no longer see indigo bubble.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Apr 17 2017, 11:12 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 17 2017, 11:12 PM

Harbormaster completed remote builds in B16538: Diff 42604.Apr 17 2017, 11:13 PM

epriestley accepted this revision.Apr 17 2017, 11:14 PM

epriestley added inline comments.

src/applications/conpherence/controller/ConpherenceController.php
70	Excellent!

This revision is now accepted and ready to land.Apr 17 2017, 11:14 PM

Closed by commit rPc98be54bf4e6: Don't show tag when no topic is set (authored by chad, committed by chad). · Explain WhyApr 17 2017, 11:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceController.php

15 lines

Diff 42605

View Options

src/applications/conpherence/controller/ConpherenceController.php

Don't show tag when no topic is setClosedPublicActions