Don't show tag when no topic is set
ClosedPublic
Actions

Authored by chad on Apr 17 2017, 11:12 PM.

Tags

None

Referenced Files

	F13182610: D17715.id42604.diff
	Fri, May 10, 12:04 AM

	Unknown Object (File)
	Tue, May 7, 6:58 AM

	Unknown Object (File)
	Fri, May 3, 4:53 AM

	Unknown Object (File)
	Thu, May 2, 8:37 AM

	Unknown Object (File)
	Sun, Apr 28, 1:07 AM

	Unknown Object (File)
	Thu, Apr 25, 12:40 AM

	Unknown Object (File)
	Thu, Apr 11, 8:33 AM

	Unknown Object (File)
	Mar 29 2024, 1:37 AM

View All 54 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPc98be54bf4e6: Don't show tag when no topic is set

Summary

Check the strlen of topic before adding a tag to the header in Conpherence.

Test Plan

Remove a topic, no longer see indigo bubble.

Diff Detail

Repository

rP Phabricator

Branch

no-topic (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16538
Build 22035: Run Core Tests
Build 22034: arc lint + arc unit

Event Timeline

chad created this revision.Apr 17 2017, 11:12 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 17 2017, 11:12 PM

Harbormaster completed remote builds in B16538: Diff 42604.Apr 17 2017, 11:13 PM

epriestley accepted this revision.Apr 17 2017, 11:14 PM

epriestley added inline comments.

src/applications/conpherence/controller/ConpherenceController.php
70	Excellent!

This revision is now accepted and ready to land.Apr 17 2017, 11:14 PM

Closed by commit rPc98be54bf4e6: Don't show tag when no topic is set (authored by chad, committed by chad). · Explain WhyApr 17 2017, 11:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceController.php

15 lines

Diff 42604

View Options

src/applications/conpherence/controller/ConpherenceController.php

Don't show tag when no topic is setClosedPublicActions