Differential D17712

Clean up Remarkup Preview on mobile
ClosedPublic
Actions

Authored by chad on Apr 17 2017, 10:08 PM.

Details

Reviewers

epriestley

Commits

rP3f45defd3451: Clean up Remarkup Preview on mobile

Summary

Some space is bleeding in here from two-column-css. Re-scope CSS.

Test Plan

Review creating a task on mobile with document preview present.

Diff Detail

Repository

rP Phabricator

Branch

remarkup-preview (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16524
Build 22018: Run Core Tests
Build 22017: arc lint + arc unit

Event Timeline

chad created this revision.Apr 17 2017, 10:08 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 17 2017, 10:08 PM

Harbormaster completed remote builds in B16523: Diff 42589.Apr 17 2017, 10:09 PM

epriestley accepted this revision.Apr 17 2017, 10:09 PM

This revision is now accepted and ready to land.Apr 17 2017, 10:09 PM

not actually used, so actually just hide it

Harbormaster completed remote builds in B16524: Diff 42590.Apr 17 2017, 10:09 PM

Closed by commit rP3f45defd3451: Clean up Remarkup Preview on mobile (authored by chad, committed by chad). · Explain WhyApr 17 2017, 10:11 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B16524: Diff 42590.Apr 17 2017, 10:11 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

phui/

phui-remarkup-preview.css

3 lines

Diff 42590

View Options

resources/celerity/map.php