Clean up Remarkup Preview on mobile
ClosedPublic
Actions

Authored by chad on Apr 17 2017, 10:08 PM.

Tags

None

Referenced Files

	F13226665: D17712.id42589.diff
	Sun, May 19, 10:20 PM

	F13219716: D17712.diff
	Sat, May 18, 8:15 PM

	F13209934: D17712.id42592.diff
	Fri, May 17, 2:56 AM

	F13208231: D17712.diff
	Thu, May 16, 11:58 AM

	F13202471: D17712.diff
	Tue, May 14, 10:43 PM

	F13176312: D17712.id42589.diff
	Wed, May 8, 12:42 PM

	Unknown Object (File)
	Thu, May 2, 6:05 AM

	Unknown Object (File)
	Thu, Apr 25, 1:57 AM

View All 97 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP3f45defd3451: Clean up Remarkup Preview on mobile

Summary

Some space is bleeding in here from two-column-css. Re-scope CSS.

Test Plan

Review creating a task on mobile with document preview present.

Diff Detail

Repository

rP Phabricator

Branch

remarkup-preview (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16523
Build 22016: Run Core Tests
Build 22015: arc lint + arc unit

Event Timeline

chad created this revision.Apr 17 2017, 10:08 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 17 2017, 10:08 PM

Harbormaster completed remote builds in B16523: Diff 42589.Apr 17 2017, 10:09 PM

epriestley accepted this revision.Apr 17 2017, 10:09 PM

This revision is now accepted and ready to land.Apr 17 2017, 10:09 PM

not actually used, so actually just hide it

Harbormaster completed remote builds in B16524: Diff 42590.Apr 17 2017, 10:09 PM

Closed by commit rP3f45defd3451: Clean up Remarkup Preview on mobile (authored by chad, committed by chad). · Explain WhyApr 17 2017, 10:11 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B16524: Diff 42590.Apr 17 2017, 10:11 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

phui/

phui-remarkup-preview.css

3 lines

Diff 42589

View Options

resources/celerity/map.php