Page MenuHomePhabricator
Differential D17677

Fix Durable Column CSS-Overload
ClosedPublic
Actions

Authored by chad on Apr 13 2017, 6:23 PM.
Tags
None
Referenced Files
F15454077: D17677.diff
Sat, Mar 29, 4:10 PM
F15452717: D17677.id42517.diff
Sat, Mar 29, 6:55 AM
F15410369: D17677.id42517.diff
Wed, Mar 19, 7:12 AM
Unknown Object (File)
Feb 17 2025, 6:32 AM
Unknown Object (File)
Feb 16 2025, 12:02 AM
Unknown Object (File)
Feb 9 2025, 9:05 AM
Unknown Object (File)
Jan 29 2025, 10:12 AM
Unknown Object (File)
Jan 29 2025, 2:51 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP2c5ee2a22556: Fix Durable Column CSS-Overload
Summary

This moves the count on the Conpherence Menu Item into a phui-list-item-count, and removes the CSS call to the entire Conphrence stack when durable column is open.

Test Plan

Test with and without the chat column, and a menu with a count

Diff Detail

Repository
rP Phabricator
Branch
fix-durable-column (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16447
Build 21890: Run Core Tests
Build 21889: arc lint + arc unit

Event Timeline

chad created this revision.Apr 13 2017, 6:23 PM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 13 2017, 6:23 PM
Harbormaster completed remote builds in B16446: Diff 42515.Apr 13 2017, 6:23 PM
epriestley accepted this revision.Apr 13 2017, 6:23 PM
This revision is now accepted and ready to land.Apr 13 2017, 6:23 PM
chad planned changes to this revision.Apr 13 2017, 6:24 PM

no this is wrong too

Harbormaster completed remote builds in B16446: Diff 42515.Apr 13 2017, 6:24 PM
chad updated this revision to Diff 42516.Apr 13 2017, 6:27 PM

un-delete code

This revision is now accepted and ready to land.Apr 13 2017, 6:27 PM
epriestley added a comment.Apr 13 2017, 6:28 PM

(Making these counts general-puropose seems potentially nice so we can flag "Subscriptions" in the new Phortune UI and such, perhaps.)

Harbormaster completed remote builds in B16447: Diff 42516.Apr 13 2017, 6:28 PM
chad added a comment.Apr 13 2017, 6:29 PM

Yeah, I like the counts, I'll probably extend them to be first class.

Closed by commit rP2c5ee2a22556: Fix Durable Column CSS-Overload (authored by chad, committed by chad). · Explain WhyApr 13 2017, 6:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
src/
applications/
search/
menuitem/
3 lines
webroot/
rsrc/
css/
application/
conpherence/
8 lines
8 lines
phui/
14 lines

Diff 42516

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/menu.css

Loading...
View Options

webroot/rsrc/css/phui/phui-list.css

Loading...
Phabricator · Built by Phacility