Paths

Table of Contentst

Tailor the CSRF check message for HTTP requests with "security.require-https"
AcceptedPublic
Actions

Authored by epriestley on Apr 13 2017, 2:55 PM.

Tags

None

Referenced Files

	F13109331: D17676.id.diff
	Sun, Apr 28, 5:37 AM

	Unknown Object (File)
	Fri, Apr 26, 5:27 PM

	Unknown Object (File)
	Thu, Apr 25, 1:02 AM

	Unknown Object (File)
	Fri, Apr 19, 6:23 PM

	Unknown Object (File)
	Fri, Apr 19, 3:59 PM

	Unknown Object (File)
	Wed, Apr 17, 8:54 AM

	Unknown Object (File)
	Sat, Mar 30, 2:00 PM

	Unknown Object (File)
	Sat, Mar 30, 4:29 AM

View All 91 Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12547: Confusing error message when trying to register an account over HTTP with `security.require-https`

Summary

Ref T12547. See that task for discussion.

Test Plan

Changed storage.default-namespace to a new value.
Upgraded database.
Enabled security.require-https.
Registered over plain HTTP.
After patch, got a more tailored exception instead of the more general/misleading one from before.

Diff Detail

Repository

rP Phabricator

Branch

tailor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16441
Build 21880: Run Core Tests
Build 21879: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 13 2017, 2:55 PM

Harbormaster completed remote builds in B16441: Diff 42510.Apr 13 2017, 2:56 PM

chad accepted this revision.Apr 13 2017, 3:05 PM

This revision is now accepted and ready to land.Apr 13 2017, 3:05 PM

Revision Contents
Changeset List

Path

Size

src/

aphront/

AphrontRequest.php

23 lines

Diff 42510

View Options

src/aphront/AphrontRequest.php

Tailor the CSRF check message for HTTP requests with "security.require-https"AcceptedPublicActions