Page MenuHomePhabricator
Differential D17660

Clean up minor form spacing
ClosedPublic
Actions

Authored by chad on Apr 12 2017, 3:09 AM.
Tags
None
Referenced Files
F15474717: D17660.diff
Sun, Apr 6, 11:20 AM
F15458497: D17660.diff
Mon, Mar 31, 4:05 AM
F15436185: D17660.id.diff
Tue, Mar 25, 12:26 PM
F15433755: D17660.id42477.diff
Tue, Mar 25, 12:31 AM
F15424016: D17660.diff
Sat, Mar 22, 7:54 PM
F15374418: D17660.diff
Mar 12 2025, 6:54 PM
F15332226: D17660.diff
Mar 7 2025, 4:51 PM
Unknown Object (File)
Feb 17 2025, 2:20 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP578ebe6c2fae: Clean up minor form spacing
Summary

Drops the inset box shadow and bumps standard UI elements from 28px to 30px. more room for activities.

Test Plan

Spaces, Editing tasks, typeaheads, mobile, desktop.

pasted_file (1×1 px, 135 KB)

Diff Detail

Repository
rP Phabricator
Branch
box-shadow-forms (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16407
Build 21827: Run Core Tests
Build 21826: arc lint + arc unit

Event Timeline

chad created this revision.Apr 12 2017, 3:09 AM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 12 2017, 3:09 AM
chad edited the test plan for this revision. (Show Details)Apr 12 2017, 3:09 AM
Harbormaster completed remote builds in B16407: Diff 42476.Apr 12 2017, 3:10 AM
epriestley accepted this revision.Apr 12 2017, 11:09 AM
This revision is now accepted and ready to land.Apr 12 2017, 11:09 AM
Closed by commit rP578ebe6c2fae: Clean up minor form spacing (authored by chad, committed by chad). · Explain WhyApr 12 2017, 2:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
webroot/
rsrc/
css/
phui/
8 lines
4 lines
8 lines

Diff 42476

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-button.css

Loading...
View Options

webroot/rsrc/css/phui/phui-comment-form.css

Loading...
View Options

webroot/rsrc/css/phui/phui-form.css

Loading...
Phabricator · Built by Phacility