Primarily, this splits individual sections of the single account page into a more managable and robust sidenav for subscriptions, billing, and managers. The functionality on the subpages is light, but I expect to build on then in coming diffs. This also starts building out a more effective "status" area on the lead page.
Details
- Reviewers
epriestley - Commits
- rPcd7547dc5760: Update UI for PhortuneAccount
- Load up default account
- Make some edits
- Click on each of the new navigation items
- Verify links to "see all" work
- Test overdue and no payment states for status
Diff Detail
- Repository
- rP Phabricator
- Branch
- phortune-account-sidenav (branched from master)
- Lint
Lint Passed Severity Location Code Message Advice src/applications/phortune/controller/account/PhortuneAccountBillingController.php:9 XHP16 TODO Comment Advice src/applications/phortune/controller/account/PhortuneAccountBillingController.php:66 XHP16 TODO Comment Advice src/applications/phortune/controller/account/PhortuneAccountManagerController.php:9 XHP16 TODO Comment Advice src/applications/phortune/controller/account/PhortuneAccountSubscriptionController.php:9 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 16404 Build 21823: Run Core Tests Build 21822: arc lint + arc unit
Event Timeline
- Consider separating "Payment Methods" and "Billing History" into separate sections? I think it wouldn't be obvious to me that I need to go to "Billing" to change payment methods, except that the icon suggests it. But "Payment Methods" is probably something I'm often interested in interacting with (because my card expired or whatever).
- "Edit Account" says "Members", curtain UI says "Managers".
- Transaction history says "Members".
- "Add Manager" isn't accessible via the UI? Maybe makes sense to put on the managers section? Oh, it looks like the code builds a button but doesn't use it? So I didn't test that bit.
src/applications/phortune/controller/account/PhortuneAccountManagerController.php | ||
---|---|---|
65–70 | poor button 😿 | |
src/applications/phortune/controller/account/PhortuneAccountViewController.php | ||
243 | srs bsns! | |
247–252 | For now, I don't think we should warn about this. I think it creates the implication that users should add a payment method without actually paying for anything, but there's currently no point to doing that, because we don't have a concept of payment methods that we'll automatically attempt to charge without further configuration. Specifically, users may hit this:
This seems potentially more confusing than the current workflow. There's also no obvious/direct way to actually add a payment method yet. Instead, we could do one of these, which I think are better solutions:
I think adding "default payment method" is totally reasonable -- it didn't really make tons of sense before subscriptions, but now does. |
I think I want to land D17585 before this so I can wire up the Add Manager stuff, if that's ok.