Page MenuHomePhabricator

Iterate over ranges correctly for encryped files
ClosedPublic

Authored by epriestley on Apr 5 2017, 1:35 PM.
Tags
None
Referenced Files
F15516933: D17623.id.diff
Fri, Apr 18, 10:23 PM
F15512408: D17623.diff
Thu, Apr 17, 10:26 AM
F15509849: D17623.id42387.diff
Wed, Apr 16, 4:35 PM
F15466014: D17623.diff
Thu, Apr 3, 12:49 AM
F15449103: D17623.id.diff
Fri, Mar 28, 8:27 AM
F15424032: D17623.id42390.diff
Sat, Mar 22, 7:57 PM
F15417729: D17623.id42387.diff
Mar 20 2025, 5:59 PM
F15416697: D17623.id42390.diff
Mar 20 2025, 1:00 PM
Subscribers
None

Details

Summary

Fixes T12079. Currently, when a file is encrypted and a request has "Content-Range", we apply the range first, then decrypt the result. This doesn't work since you can't start decrypting something from somewhere in the middle (at least, not with our cipher selection).

Instead: decrypt the result, then apply the range.

Test Plan

Added failing unit tests, made them pass

Diff Detail

Repository
rP Phabricator
Branch
files13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16317
Build 21693: Run Core Tests
Build 21692: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 5 2017, 4:35 PM
This revision was automatically updated to reflect the committed changes.