Page MenuHomePhabricator

Immediately deactivate remarkup autocomplete if there's no query
ClosedPublic

Authored by epriestley on Mar 30 2017, 3:41 PM.
Tags
None
Referenced Files
F19607672: D17583.diff
Feb 3 2026, 11:53 AM
F19530815: D17583.id42298.diff
Jan 20 2026, 12:30 AM
F19527314: D17583.id42298.diff
Jan 19 2026, 12:30 AM
F19039017: D17583.id42298.diff
Nov 26 2025, 6:36 AM
F19036915: D17583.id.diff
Nov 25 2025, 9:18 PM
F19028977: D17583.diff
Nov 24 2025, 4:47 PM
F18856386: D17583.id42304.diff
Nov 1 2025, 9:31 AM
F18856026: D17583.id42304.diff
Nov 1 2025, 7:37 AM
Subscribers
None

Details

Summary

Fixes T12479. If you end a line with a character like ":" in a context which can trigger autocomplete (e.g., .:), then try to make a newline, we swallow the keystroke.

Instead, allow the keystroke through if the user hasn't typed anything else yet.

Test Plan
  • Autocompleted emoji and users normally.
  • In an empty textarea, typed .:<return>, got a newline instead of a swallowed keystroke.

Diff Detail

Repository
rP Phabricator
Branch
emoji2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16224
Build 21548: Run Core Tests
Build 21547: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 30 2017, 3:58 PM
This revision was automatically updated to reflect the committed changes.