Page MenuHomePhabricator

Modernize PhortuneAccount and PhortuneMerchant
AbandonedPublic

Authored by chad on Mar 29 2017, 6:19 PM.
Tags
None
Referenced Files
F13317737: D17579.diff
Thu, Jun 13, 9:50 AM
F13306852: D17579.diff
Sun, Jun 9, 10:57 AM
F13270692: D17579.id42290.diff
Wed, May 29, 10:24 AM
F13248721: D17579.diff
Fri, May 24, 3:58 AM
F13240632: D17579.id42293.diff
Wed, May 22, 3:44 PM
F13227738: D17579.diff
May 20 2024, 5:03 AM
F13209854: D17579.id.diff
May 17 2024, 2:34 AM
Unknown Object (File)
May 6 2024, 10:28 PM
Subscribers

Details

Reviewers
epriestley
Summary

Modernizes PhortuneAccount and PhortuneMerchant

  • Split pages into more logical pieces instead of a big page of tables
  • Implement EditEngine in PhortuneAccount
  • Add modular transactions to PhortuneAccount and PhortuneMerchant
  • Add mail support for both
  • Swap "members" for "managers" to better differentiate from instance users.
  • Lots of icons!
  • More validation
Test Plan

TODO, having issues with EDGE writing and validation

Event Timeline

  • basic mail support, fix lint issues
  • fix validation of edges on PhortuneAccount

This doing like 5 different things, can we split it apart? e.g.:

  • Move/rename controllers.
  • Switch to modular transactions.
  • "Manager" string updates.
  • UI updates to menus.
  • New features/workflows after all that infrastructure stuff is in place.

Phortune is somewhat difficult to test convincingly and doesn't get much usage during the week until we deploy it, so I'd like to take extra care here to try to spread risk across a lot of small, low-risk events instead of concentrating it into a gigantic "rewrite everything" change that leaves me scrambling to figure out what's going on after I deploy it and billing breaks.