Page MenuHomePhabricator

Clean up a few more daemon behaviors
ClosedPublic

Authored by epriestley on Mar 24 2017, 8:44 PM.
Tags
None
Referenced Files
F19121092: D17560.diff
Tue, Dec 9, 10:17 PM
F19012520: D17560.id42232.diff
Nov 22 2025, 1:14 PM
F18982349: D17560.diff
Nov 17 2025, 6:39 AM
F18938994: D17560.diff
Nov 11 2025, 5:46 AM
F18859023: D17560.id42230.diff
Nov 1 2025, 11:48 PM
F18774583: D17560.diff
Oct 10 2025, 3:02 PM
F18772879: D17560.id42232.diff
Oct 9 2025, 5:27 AM
F18741428: D17560.id.diff
Oct 2 2025, 1:10 PM
Subscribers
None

Details

Summary

Ref T12298.

  • If all daemons in all pools are hibernating already, we may exit immediately without sending EXIT events and fail to update the web UI.
  • A max() should be min() ("sleep for at most 180 seconds", not "sleep for at least 180 seconds").
  • If there are no daemons in a pool (unlikely/theoretical), we might not set the shutdown flag on the pool correctly.
  • An autoscale message may actually mean that a pool is exiting.
Test Plan
  • Ran bin/phd debug task, waited for daemon to hibernate, killed it, saw it vanish from daemon console.
  • Saw it hibernate for 60s, not 180s.
  • Uh, killed a pool real fast and nothing broke? This one is hard/impossible to test.
  • Read the newer autoscale message.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable