Page MenuHomePhabricator

Use ModularTransactions for accept/reject/resign in "differential.createcomment"
ClosedPublic

Authored by epriestley on Mar 20 2017, 4:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 10:18 AM
Unknown Object (File)
Thu, Jan 30, 10:35 AM
Unknown Object (File)
Tue, Jan 28, 2:18 AM
Unknown Object (File)
Tue, Jan 28, 2:18 AM
Unknown Object (File)
Tue, Jan 28, 2:18 AM
Unknown Object (File)
Mon, Jan 27, 4:50 PM
Unknown Object (File)
Sat, Jan 25, 2:33 PM
Unknown Object (File)
Fri, Jan 24, 7:32 PM
Subscribers
None

Details

Summary

Ref T10967. differential.createcomment is a frozen API method which has been obsoleted by differential.revision.edit.

It is the only remaining way to apply an "accept", "reject", or "resign" action using the old "ACTION" code.

Instead of using the old code, sneakly apply a new type of transaction in these cases instead.

Then, remove all the remaining old code for this stuff on the write pathways.

Test Plan
  • Used "differential.createcomment" to accept, reject, and resign from a revision.
  • Grepped for all removed ACTION_X constants, found them only in rendering code.

Diff Detail

Repository
rP Phabricator
Branch
rev3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16037
Build 21265: Run Core Tests
Build 21264: arc lint + arc unit