Make "Can Interact" and logged-out users interact more gracefully
ClosedPublic
Actions

Authored by epriestley on Mar 9 2017, 4:46 PM.

Details

Reviewers

chad

Maniphest Tasks

T12378: "This task has been locked" on all logged out tasks

Commits

rPd0c648dfa53b: Make "Can Interact" and logged-out users interact more gracefully

Summary

Fixes T12378. Two minor issues here:

CAN_INTERACT on tasks uses "USER", but should just use the view policy, which may be more permissive ("PUBLIC").
CAN_INTERACT is currently prevented from being "PUBLIC" by additional safeguards. Define an explicit capability object for the permission which returns true from shouldAllowPublicPolicySetting().

Test Plan

Viewed an unlocked task as a logged-out user, saw "login to comment" instead of "locked".
Viewed a locked task as a logged-out user, saw "locked".

Diff Detail

Repository

rP Phabricator

Branch

lock1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15953
Build 21134: Run Core Tests
Build 21133: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 9 2017, 4:46 PM

epriestley added inline comments.Mar 9 2017, 4:47 PM

src/applications/policy/capability/PhabricatorPolicyCanInteractCapability.php
13	We can't reasonably specialize this string, but it won't currently ever appear in the UI.

Harbormaster completed remote builds in B15953: Diff 42047.Mar 9 2017, 4:47 PM

chad accepted this revision.Mar 9 2017, 4:48 PM

This revision is now accepted and ready to land.Mar 9 2017, 4:48 PM

I had mistakenly believed this block was handling the "log in to comment" case, but it doesn't:

https://secure.phabricator.com/source/phabricator/browse/master/src/applications/transactions/editengine/PhabricatorEditEngine.php;4c7d464f8bf2627ef7455596fde2ae5667e67a57$1565-1570

The block already has a comment describing the case it does handle, so I think this was just carelessness on my part and don't see any technical change we can make to make this more clear.

We could add CAN_INTERACT tests to the test suite to shore this up a little bit, but I think the feature is potentially still in flux so I want to wait to pursue that.

Closed by commit rPd0c648dfa53b: Make "Can Interact" and logged-out users interact more gracefully (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2017, 4:51 PM

This revision was automatically updated to reflect the committed changes.