Prevent awarding/revoking tokens when a task is locked
ClosedPublic
Actions

Authored by epriestley on Mar 4 2017, 4:07 PM.

Tags

None

Referenced Files

	F15457832: D17461.diff
	Sun, Mar 30, 7:16 PM

	F15441559: D17461.id41994.diff
	Wed, Mar 26, 6:48 PM

	F15440921: D17461.id41990.diff
	Wed, Mar 26, 3:28 PM

	F15430085: D17461.id.diff
	Mon, Mar 24, 5:36 AM

	F15429387: D17461.diff
	Mon, Mar 24, 1:53 AM

	F15396332: D17461.id.diff
	Sun, Mar 16, 1:34 PM

	F15336882: D17461.id41994.diff
	Sun, Mar 9, 3:01 AM

	Unknown Object (File)
	Mar 3 2025, 7:59 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12335: Ability to lock a task to prevent further edits

Commits

rP9ccef52d6c3f: Prevent awarding/revoking tokens when a task is locked

Summary

Ref T12335. Allows you to lock tasks to keep your precious tokens.

Test Plan

Awarded tokens to an unlocked task.
Locked the task.
Could no longer award/rescind tokens.

Diff Detail

Repository

rP Phabricator

Branch

token1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15894
Build 21043: Run Core Tests
Build 21042: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 4 2017, 4:07 PM

Harbormaster completed remote builds in B15894: Diff 41990.Mar 4 2017, 4:08 PM

chad accepted this revision.Mar 4 2017, 4:20 PM

This revision is now accepted and ready to land.Mar 4 2017, 4:20 PM

Closed by commit rP9ccef52d6c3f: Prevent awarding/revoking tokens when a task is locked (authored by epriestley, committed by epriestley). · Explain WhyMar 4 2017, 5:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

tokens/

controller/

PhabricatorTokenGiveController.php

18 lines

event/

PhabricatorTokenUIEventListener.php

9 lines

Diff 41990

View Options

src/applications/tokens/controller/PhabricatorTokenGiveController.php