Fix an issue with FileFinder finding "." as a directory
ClosedPublic
Actions

Authored by epriestley on Mar 3 2017, 9:17 PM.

Tags

None

Referenced Files

	F15425940: D17455.id41979.diff
	Sun, Mar 23, 6:41 AM

	F15424899: D17455.id41979.diff
	Sun, Mar 23, 12:59 AM

	F15416680: D17455.id.diff
	Thu, Mar 20, 12:57 PM

	F15416338: D17455.id.diff
	Thu, Mar 20, 10:34 AM

	F15413737: D17455.diff
	Wed, Mar 19, 9:00 PM

	F15389178: D17455.id41977.diff
	Sat, Mar 15, 4:58 AM

	Unknown Object (File)
	Thu, Feb 27, 4:23 AM

	Unknown Object (File)
	Feb 21 2025, 3:13 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rPHUc26f7b429f71: Fix an issue with FileFinder finding "." as a directory

Summary

See D17430. This is buggy and hasn't come up before because we don't usually use the "d" (directory) mode.

Test Plan

Added a unit test and made it pass.

Diff Detail

Repository

rPHU libphutil

Branch

ffinder1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15881
Build 21022: Run Core Tests
Build 21021: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 3 2017, 9:17 PM

Harbormaster completed remote builds in B15881: Diff 41977.Mar 3 2017, 9:17 PM

Harbormaster completed remote builds in B15881: Diff 41977.

chad accepted this revision.Mar 3 2017, 9:24 PM

This revision is now accepted and ready to land.Mar 3 2017, 9:24 PM

Closed by commit rPHUc26f7b429f71: Fix an issue with FileFinder finding "." as a directory (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2017, 9:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

filesystem/

FileFinder.php

13 lines

__tests__/

FileFinderTestCase.php

22 lines

Diff 41977

View Options

src/filesystem/FileFinder.php

View Options

src/filesystem/tests/FileFinderTestCase.php

Fix an issue with FileFinder finding "." as a directoryClosedPublicActions