Page MenuHomePhabricator
Differential D17450

Remove dashboard footer
ClosedPublic
Actions

Authored by chad on Mar 2 2017, 5:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 4, 1:27 PM
Unknown Object (File)
Fri, Dec 20, 3:00 PM
Unknown Object (File)
Dec 4 2024, 6:00 AM
Unknown Object (File)
Nov 20 2024, 1:25 AM
Unknown Object (File)
Nov 15 2024, 9:53 PM
Unknown Object (File)
Nov 6 2024, 1:44 AM
Unknown Object (File)
Oct 29 2024, 10:10 AM
Unknown Object (File)
Oct 21 2024, 11:41 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP87304e360f1f: Remove dashboard footer
Summary

Doesn't seem popular, will rethink dashboard editing again in the future at some point.

Test Plan

Review a dashboard, edit, install.

Diff Detail

Repository
rP Phabricator
Branch
dashboard-footer (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15853
Build 20982: Run Core Tests
Build 20981: arc lint + arc unit

Event Timeline

chad created this revision.Mar 2 2017, 5:58 AM
Herald added a subscriber: Korvin. · View Herald TranscriptMar 2 2017, 5:58 AM
Harbormaster completed remote builds in B15853: Diff 41949.Mar 2 2017, 5:59 AM
epriestley accepted this revision.Mar 2 2017, 11:57 AM
This revision is now accepted and ready to land.Mar 2 2017, 11:57 AM
Closed by commit rP87304e360f1f: Remove dashboard footer (authored by chad, committed by chad). · Explain WhyMar 2 2017, 2:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
dashboard/
engine/
28 lines
webroot/
rsrc/
css/
application/
dashboard/
14 lines

Diff 41949

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php

Loading...
View Options

webroot/rsrc/css/application/dashboard/dashboard.css

Loading...
Phabricator · Built by Phacility