Page MenuHomePhabricator

Fix an issue where daemons can stick in a pool
ClosedPublic

Authored by epriestley on Feb 28 2017, 4:10 PM.
Tags
None
Referenced Files
F15428855: D17433.id41916.diff
Sun, Mar 23, 10:49 PM
F15427234: D17433.id41917.diff
Sun, Mar 23, 1:24 PM
F15409768: D17433.diff
Wed, Mar 19, 5:12 AM
F15392724: D17433.diff
Sat, Mar 15, 5:15 PM
Unknown Object (File)
Feb 26 2025, 4:41 PM
Unknown Object (File)
Feb 21 2025, 3:13 PM
Unknown Object (File)
Feb 17 2025, 11:44 PM
Unknown Object (File)
Feb 9 2025, 3:24 AM
Subscribers
None

Details

Summary

Ref T12331. Root problem is the unset($daemon) just unsets a key in a local variable, rather than actually discarding the daemon.

Add some logging to make this more clear and clean up some %d vs %s stuff.

Test Plan
  • Ran a pool with bin/phd debug task --pool N, let it scale up, let it scale down, used bin/worker flood to add more tasks.
  • Before patch, the ghost daemons took up the slots in the pool.
  • After patch, the ghost daemons got removed properly and were replaced with fresh daemons.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/daemon/PhutilDaemonPool.php
181–188

Specifically, this is the actual bugfix.

🤷 ¯\_(ツ)_/¯

This revision is now accepted and ready to land.Feb 28 2017, 4:12 PM
This revision was automatically updated to reflect the committed changes.