Page MenuHomePhabricator
Differential D17388

Fix bad JS rendering in "Allow Desktop Notifications" workflow
ClosedPublic
Actions

Authored by epriestley on Feb 20 2017, 8:51 PM.
Tags
None
Referenced Files
F15416292: D17388.id41811.diff
Thu, Mar 20, 10:24 AM
F15411547: D17388.id41811.diff
Wed, Mar 19, 9:26 AM
F15407731: D17388.id.diff
Tue, Mar 18, 7:12 PM
F15393986: D17388.id41811.diff
Sat, Mar 15, 11:18 PM
F15374777: D17388.id41811.diff
Wed, Mar 12, 8:17 PM
F15336275: D17388.diff
Sat, Mar 8, 6:36 PM
F15335340: D17388.id41811.diff
Sat, Mar 8, 3:06 PM
Unknown Object (File)
Feb 17 2025, 1:56 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
rPab9c1b73b532: Fix bad JS rendering in "Allow Desktop Notifications" workflow
Summary

See downstream https://phabricator.kde.org/T5404. This code was doing some .firstChild shenanigans which didn't survive some UI refactoring.

This whole UI is a little iffy but just unbreak it for now.

Test Plan

Allowed and rejected desktop notifications, got largely reasonable UI rendering.

Diff Detail

Repository
rP Phabricator
Branch
notif1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15708
Build 20750: Run Core Tests
Build 20749: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 20 2017, 8:51 PM
Harbormaster completed remote builds in B15708: Diff 41811.Feb 20 2017, 8:52 PM
chad accepted this revision.Feb 20 2017, 8:52 PM
This revision is now accepted and ready to land.Feb 20 2017, 8:52 PM
Closed by commit rPab9c1b73b532: Fix bad JS rendering in "Allow Desktop Notifications" workflow (authored by epriestley, committed by epriestley). · Explain WhyFeb 20 2017, 8:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
applications/
settings/
panel/
12 lines
webroot/
rsrc/
js/
application/
aphlict/
16 lines

Diff 41811

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/settings/panel/PhabricatorDesktopNotificationsSettingsPanel.php

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-desktop-notifications-control.js

Loading...
Phabricator · Built by Phacility