Page MenuHomePhabricator

Fix bad JS rendering in "Allow Desktop Notifications" workflow
ClosedPublic

Authored by epriestley on Feb 20 2017, 8:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 2, 12:11 AM
Unknown Object (File)
Tue, Jan 28, 4:34 PM
Unknown Object (File)
Fri, Jan 24, 7:14 PM
Unknown Object (File)
Fri, Jan 24, 7:14 PM
Unknown Object (File)
Fri, Jan 24, 7:14 PM
Unknown Object (File)
Fri, Jan 24, 7:14 PM
Unknown Object (File)
Thu, Jan 23, 10:31 PM
Unknown Object (File)
Wed, Jan 22, 11:03 AM
Subscribers
None

Details

Summary

See downstream https://phabricator.kde.org/T5404. This code was doing some .firstChild shenanigans which didn't survive some UI refactoring.

This whole UI is a little iffy but just unbreak it for now.

Test Plan

Allowed and rejected desktop notifications, got largely reasonable UI rendering.

Diff Detail

Repository
rP Phabricator
Branch
notif1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15708
Build 20750: Run Core Tests
Build 20749: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 20 2017, 8:52 PM
This revision was automatically updated to reflect the committed changes.