Paths

Table of Contentst

Differential D17377

Fix errors found by PHPStan
ClosedPublic
Actions

Authored by vrana on Feb 17 2017, 5:33 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rP9f3cde4db765: Fix errors found by PHPStan

Test Plan

None.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 15678
Build 20708: Run Core Tests
Build 20707: arc lint + arc unit

Event Timeline

vrana created this revision.Feb 17 2017, 5:33 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 17 2017, 5:33 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B15678: Diff 41783.Feb 17 2017, 5:34 PM

vrana added inline comments.Feb 17 2017, 5:37 PM

src/applications/diffusion/editor/DiffusionCommitEditEngine.php
114	LOL.

(These are from PHPStan's level 5 errors.)

Good catch! What's the underlying rule that detected that? (Variable assignment without use before next assignment?)

src/applications/diffusion/editor/DiffusionCommitEditEngine.php
114	Ugh, thanks.

This revision is now accepted and ready to land.Feb 17 2017, 5:46 PM

Comparing a string to false with ===.

Closed by commit rP9f3cde4db765: Fix errors found by PHPStan (authored by vrana, committed by vrana). · Explain WhyFeb 18 2017, 9:25 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D17460: Fix a constant typo in Diviner ("DECLARATAION" -> "TION").Mar 4 2017, 3:17 PM

epriestley mentioned this in rPd5baf2fe3755: Fix a constant typo in Diviner ("DECLARATAION" -> "TION").Mar 4 2017, 5:54 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

util/

CalendarTimeUtil.php

4 lines

daemon/

management/

PhabricatorDaemonManagementRestartWorkflow.php

2 lines

PhabricatorDaemonManagementStartWorkflow.php

2 lines

diffusion/

conduit/

DiffusionBrowseQueryConduitAPIMethod.php

2 lines

controller/

DiffusionRepositoryController.php

4 lines

editor/

DiffusionCommitEditEngine.php

1 line

herald/

HeraldPreCommitContentAdapter.php

2 lines

query/

lowlevel/

DiffusionLowLevelResolveRefsQuery.php

4 lines

diviner/

atomizer/

DivinerPHPAtomizer.php

2 lines

metamta/

storage/

PhabricatorMetaMTAMail.php

3 lines

phortune/

management/

PhabricatorPhortuneManagementInvoiceWorkflow.php

2 lines

repository/

engine/

PhabricatorRepositoryDiscoveryEngine.php

2 lines

PhabricatorRepositoryMirrorEngine.php

2 lines

PhabricatorRepositoryPullEngine.php

2 lines

infrastructure/

markup/

PhabricatorMarkupEngine.php

2 lines

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

1 line

storage/

lisk/

LiskDAO.php

17 lines

time/

PhabricatorTime.php

4 lines

view/

phui/

calendar/

PHUICalendarMonthView.php

2 lines

viewutils.php

2 lines

Diff 41783

View Options

src/applications/calendar/util/CalendarTimeUtil.php

View Options

src/applications/daemon/management/PhabricatorDaemonManagementRestartWorkflow.php

View Options

src/applications/daemon/management/PhabricatorDaemonManagementStartWorkflow.php

View Options

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php

View Options

src/applications/diviner/atomizer/DivinerPHPAtomizer.php

View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

View Options

src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php

View Options

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

View Options

src/applications/repository/engine/PhabricatorRepositoryMirrorEngine.php

View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

View Options

src/infrastructure/storage/lisk/LiskDAO.php

View Options

src/infrastructure/time/PhabricatorTime.php

View Options

src/view/phui/calendar/PHUICalendarMonthView.php

View Options

Fix errors found by PHPStanClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41783

src/applications/calendar/util/CalendarTimeUtil.php

src/applications/daemon/management/PhabricatorDaemonManagementRestartWorkflow.php

src/applications/daemon/management/PhabricatorDaemonManagementStartWorkflow.php

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php

src/applications/diffusion/controller/DiffusionRepositoryController.php

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php

src/applications/diviner/atomizer/DivinerPHPAtomizer.php

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

src/applications/phortune/management/PhabricatorPhortuneManagementInvoiceWorkflow.php

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

src/applications/repository/engine/PhabricatorRepositoryMirrorEngine.php

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

src/infrastructure/markup/PhabricatorMarkupEngine.php

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

src/infrastructure/storage/lisk/LiskDAO.php

src/infrastructure/time/PhabricatorTime.php

src/view/phui/calendar/PHUICalendarMonthView.php

src/view/viewutils.php

Fix errors found by PHPStan
ClosedPublic
Actions

Revision Contents
Changeset List