Differential D17375

Fix errors found by PHPStan
ClosedPublic
Actions

Authored by vrana on Feb 17 2017, 5:31 PM.

Tags

None

Referenced Files

	F15374249: D17375.id41803.diff
	Wed, Mar 12, 5:52 PM

	F15334900: D17375.diff
	Sat, Mar 8, 1:12 PM

	Unknown Object (File)
	Mon, Mar 3, 8:31 AM

	Unknown Object (File)
	Sun, Mar 2, 8:16 AM

	Unknown Object (File)
	Fri, Feb 21, 3:11 PM

	Unknown Object (File)
	Feb 9 2025, 3:18 AM

	Unknown Object (File)
	Feb 3 2025, 6:21 AM

	Unknown Object (File)
	Feb 1 2025, 6:14 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU5e14a5b17809: Fix errors found by PHPStan

Test Plan

None.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 15676
Build 20704: Run Core Tests
Build 20703: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	PhutilURITestCase::Unknown Unit Message ("") Assertion failed, expected values to be equal (at PhutilURITestCase.php:87). Expected: 'good.com#u' Actual: ''
	1 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 2 assertions passed.
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed.
		View Full Test Results (1 Failed · 415 Passed · 2 Skipped)

Event Timeline

vrana created this revision.Feb 17 2017, 5:31 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 17 2017, 5:31 PM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.Feb 17 2017, 5:43 PM

This revision is now accepted and ready to land.Feb 17 2017, 5:43 PM

Closed by commit rPHU5e14a5b17809: Fix errors found by PHPStan (authored by vrana, committed by vrana). · Explain WhyFeb 18 2017, 9:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

argument/

PhutilArgumentParser.php

3 lines

xsprintf/

6 lines

Diff 41781

src/parser/argument/PhutilArgumentParser.php

Loading...

src/xsprintf/csprintf.php

Loading...