Page MenuHomePhabricator
Differential D17336

Allow task graph task titles to go full width
ClosedPublic
Actions

Authored by chad on Feb 10 2017, 6:41 PM.
Tags
None
Referenced Files
F15399938: D17336.id.diff
Mon, Mar 17, 8:39 AM
F15379661: D17336.diff
Thu, Mar 13, 10:39 PM
Unknown Object (File)
Wed, Feb 26, 10:18 PM
Unknown Object (File)
Feb 9 2025, 3:15 AM
Unknown Object (File)
Feb 9 2025, 3:15 AM
Unknown Object (File)
Feb 9 2025, 3:15 AM
Unknown Object (File)
Feb 1 2025, 9:55 AM
Unknown Object (File)
Jan 25 2025, 7:54 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12213: Task title is truncated in task graph, even if there is enough space
Commits
rP4176bdeb5be0: Allow task graph task titles to go full width
Summary

Fixes T12213. Removes truncation and allows titles to be full width if needed.

Test Plan

Chrome / Firefox / Safari on Mac, mobile and desktop widths.

pasted_file (1×3 px, 370 KB)

Diff Detail

Repository
rP Phabricator
Branch
table-sub (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15590
Build 20572: Run Core Tests
Build 20571: arc lint + arc unit

Event Timeline

chad created this revision.Feb 10 2017, 6:41 PM
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 10 2017, 6:41 PM
Harbormaster completed remote builds in B15590: Diff 41693.Feb 10 2017, 6:41 PM
chad retitled this revision from All task graph task titles to go full width to Allow task graph task titles to go full width.Feb 10 2017, 6:46 PM
chad edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Feb 10 2017, 6:55 PM

What an intuitive behavior for max-width to have.

This revision is now accepted and ready to land.Feb 10 2017, 6:55 PM
chad added a comment.Feb 10 2017, 6:56 PM

http://stackoverflow.com/questions/26292408/why-does-this-behave-the-way-it-does-with-max-width-0

Closed by commit rP4176bdeb5be0: Allow task graph task titles to go full width (authored by chad, committed by chad). · Explain WhyFeb 10 2017, 6:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
infrastructure/
graph/
6 lines
webroot/
rsrc/
css/
aphront/
4 lines

Diff 41693

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/graph/ManiphestTaskGraph.php

Loading...
View Options

webroot/rsrc/css/aphront/table-view.css

Loading...
Phabricator · Built by Phacility