Page MenuHomePhabricator
Differential D17246

Add some sort of sort to Emoji Autocomplete
ClosedPublic
Actions

Authored by chad on Jan 25 2017, 4:16 AM.
Tags
None
Referenced Files
F18739691: D17246.id41480.diff
Wed, Oct 1, 10:34 PM
F18739237: D17246.diff
Wed, Oct 1, 8:30 PM
F18703845: D17246.diff
Sun, Sep 28, 5:14 AM
F18642113: D17246.id.diff
Thu, Sep 18, 10:35 PM
F18627702: D17246.diff
Tue, Sep 16, 4:35 AM
F18528969: D17246.id.diff
Sat, Sep 6, 10:34 PM
F18508434: D17246.id.diff
Fri, Sep 5, 2:49 AM
F18500509: D17246.diff
Thu, Sep 4, 9:07 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12139: Add a proper emoji picker to Remarkup bar
Commits
rP01b35cdc120b: Add some sort of sort to Emoji Autocomplete
Summary

Ref T12139. Adds sorting by shortname. Also I sorted everything else. No reason. It didn't help

Test Plan

:star

Diff Detail

Repository
rP Phabricator
Branch
emoji-sort (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15369
Build 20241: Run Core Tests
Build 20240: arc lint + arc unit

Event Timeline

chad created this revision.Jan 25 2017, 4:16 AM
Herald added a subscriber: Korvin. · View Herald TranscriptJan 25 2017, 4:16 AM
Harbormaster completed remote builds in B15369: Diff 41479.Jan 25 2017, 4:17 AM
epriestley accepted this revision.Jan 25 2017, 4:18 AM
epriestley added inline comments.
scripts/celerity/generate_emoji.php
43

I believe this won't impact the display order in the UI, but it will make future manifest.json diffs smaller so it's probably good anyway.

This revision is now accepted and ready to land.Jan 25 2017, 4:18 AM
chad added a comment.Jan 25 2017, 4:19 AM

where do you want the ' '

chad added a comment.Jan 25 2017, 4:20 AM

n/m

Closed by commit rP01b35cdc120b: Add some sort of sort to Emoji Autocomplete (authored by chad, committed by chad). · Explain WhyJan 25 2017, 4:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
emoji/
2892 lines
scripts/
celerity/
6 lines
src/
applications/
macro/
typeahead/
3 lines

Diff 41479

View Options

resources/emoji/manifest.json

Loading...
View Options

scripts/celerity/generate_emoji.php

Loading...
View Options

src/applications/macro/typeahead/PhabricatorEmojiDatasource.php

Loading...
Phabricator · Built by Phacility