Page MenuHomePhabricator
Differential D17234

Put "View Edit History" above "Remove Comment" in timeline comment action dropdown
ClosedPublic
Actions

Authored by epriestley on Jan 20 2017, 3:40 PM.
Tags
None
Referenced Files
F13238493: D17234.id41448.diff
Tue, May 21, 7:35 PM
F13223008: D17234.diff
Sun, May 19, 4:11 AM
F13207964: D17234.id41448.diff
Thu, May 16, 6:51 AM
F13207473: D17234.id41449.diff
Thu, May 16, 12:18 AM
F13199309: D17234.diff
Mon, May 13, 1:46 PM
F13177606: D17234.diff
Wed, May 8, 7:50 PM
Unknown Object (File)
Wed, May 1, 11:06 PM
Unknown Object (File)
Mon, Apr 29, 4:10 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12131: Edit History inserts itself wherever it feels like
Commits
rP98a29f3de90a: Put "View Edit History" above "Remove Comment" in timeline comment action…
Summary

Fixes T12131.

Test Plan

Screen Shot 2017-01-20 at 7.39.53 AM.png (278×422 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Branch
order1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15337
Build 20192: Run Core Tests
Build 20191: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 20 2017, 3:40 PM
Harbormaster completed remote builds in B15337: Diff 41448.Jan 20 2017, 3:41 PM
chad accepted this revision.Jan 20 2017, 4:06 PM

Well there go my morning plans.

This revision is now accepted and ready to land.Jan 20 2017, 4:06 PM
Closed by commit rP98a29f3de90a: Put "View Edit History" above "Remove Comment" in timeline comment action… (authored by epriestley, committed by chad). · Explain WhyJan 20 2017, 4:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
16 lines

Diff 41448

View Options

src/view/phui/PHUITimelineEventView.php

Loading...
Phabricator · Built by Phacility