Page MenuHomePhabricator
Differential D17234

Put "View Edit History" above "Remove Comment" in timeline comment action dropdown
ClosedPublic
Actions

Authored by epriestley on Jan 20 2017, 3:40 PM.
Tags
None
Referenced Files
F15524512: D17234.id41448.diff
Mon, Apr 21, 8:32 AM
F15516493: D17234.id.diff
Fri, Apr 18, 7:11 PM
F15513993: D17234.diff
Thu, Apr 17, 11:34 PM
F15513484: D17234.diff
Thu, Apr 17, 7:17 PM
F15485038: D17234.diff
Wed, Apr 9, 9:24 PM
F15466122: D17234.id.diff
Thu, Apr 3, 1:50 AM
F15465486: D17234.diff
Wed, Apr 2, 7:27 PM
F15438160: D17234.diff
Mar 25 2025, 11:37 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12131: Edit History inserts itself wherever it feels like
Commits
rP98a29f3de90a: Put "View Edit History" above "Remove Comment" in timeline comment action…
Summary

Fixes T12131.

Test Plan

Screen Shot 2017-01-20 at 7.39.53 AM.png (278×422 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Branch
order1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15337
Build 20192: Run Core Tests
Build 20191: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 20 2017, 3:40 PM
Harbormaster completed remote builds in B15337: Diff 41448.Jan 20 2017, 3:41 PM
chad accepted this revision.Jan 20 2017, 4:06 PM

Well there go my morning plans.

This revision is now accepted and ready to land.Jan 20 2017, 4:06 PM
Closed by commit rP98a29f3de90a: Put "View Edit History" above "Remove Comment" in timeline comment action… (authored by epriestley, committed by chad). · Explain WhyJan 20 2017, 4:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
16 lines

Diff 41448

View Options

src/view/phui/PHUITimelineEventView.php

Loading...
Phabricator · Built by Phacility