Differential D17231

Mark fields as required on MenuItems
ClosedPublic
Actions

Authored by chad on Jan 19 2017, 9:32 PM.

Details

Reviewers

epriestley

Commits

rP14dfff9c99d2: Mark fields as required on MenuItems

Summary

Mark required fields as required. Though in testing, none of these work.

Test Plan

Try to save a form without an app/project/dashboard and see success (not expected)

Diff Detail

Repository

rP Phabricator

Branch

is-required (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15332
Build 20185: Run Core Tests
Build 20184: arc lint + arc unit

Event Timeline

chad created this revision.Jan 19 2017, 9:32 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 19 2017, 9:32 PM

Harbormaster completed remote builds in B15332: Diff 41443.Jan 19 2017, 9:33 PM

This only controls the UI, I can counterdiff you for actual validation logic. I think there's an existing TODO on "Link" items anyway since they have no validation on typing garbage in for the link target, which can be confusing since security code then nukes it on the display side.

This revision is now accepted and ready to land.Jan 19 2017, 9:39 PM

Closed by commit rP14dfff9c99d2: Mark fields as required on MenuItems (authored by chad, committed by chad). · Explain WhyJan 19 2017, 9:41 PM

This revision was automatically updated to reflect the committed changes.