Not sure this page is really providing any value, the timeline always says "edited this object" and there is a list of actions. Seems we could move actions back to the profile proper, but they feel very... engineery to me. Or we could fix the timeline stories, but my guess is they aren't useful or we would have gotten such feedback.
Details
Details
- Reviewers
epriestley - Commits
- rP1bcc8a3d98e0: Remove timeline from Profile Manage
Review manage page, timeline is gone. Page is clean.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- prof-manage (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 15330 Build 20182: Run Core Tests Build 20181: arc lint + arc unit
Event Timeline
Comment Actions
I'd like to fix this timeline to show administrative events, particularly account disables/enables. This information is indirectly available in People > Activity Logs but inconvenient to access. However, I can put the timeline back after I fix it.
Comment Actions
You could, but it's enough work that I don't think it's worthwhile until we do a general update here (maybe related to generally improving logging/security stuff?), since "Disable / Enable" isn't transactional right now.
You could fix the feed as it exists today by adding rendering methods to the stuff in src/applications/people/customfield/, I think -- they're missing getApplicationTransactionTitle() methods, mostly. That would get us "epriestley changed titles from X to Y" instead of "epriestley edited this object.", at least.