Page MenuHomePhabricator

Allow users to re-accept or re-reject a revision if they have authority over package/project reviewers not yet in the target state
ClosedPublic

Authored by epriestley on Jan 18 2017, 9:01 PM.
Tags
None
Referenced Files
F15470500: D17226.diff
Fri, Apr 4, 11:04 PM
F15467795: D17226.diff
Thu, Apr 3, 6:03 PM
F15460515: D17226.id41430.diff
Mon, Mar 31, 11:29 PM
F15459702: D17226.id41434.diff
Mon, Mar 31, 3:19 PM
F15452624: D17226.id.diff
Sat, Mar 29, 6:20 AM
F15448337: D17226.diff
Fri, Mar 28, 4:16 AM
F15434142: D17226.id41434.diff
Tue, Mar 25, 2:13 AM
F15422939: D17226.id.diff
Sat, Mar 22, 11:32 AM
Subscribers
None

Details

Summary

To set this up:

  • alice accepts a revision.
  • Something adds a package or project she has authority over as a reviewer.
  • Because alice has already accepted, she can not re-accept, but she should be able to (in order to accept on behalf of the new project or package).
Test Plan
  • Created a revision.
  • Accepted as user "dog".
  • Added "dog project".
  • Re-accepted.
  • Could not three-accept.
  • Removed "dog project.
  • Rejected.
  • Added "dog project".
  • Re-rejected.
  • Could not three-reject.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable