Fix $classes not imploding properly in list view
ClosedPublic
Actions

Authored by chad on Jan 17 2017, 10:55 PM.

Tags

None

Referenced Files

	F15452266: D17216.id41409.diff
	Sat, Mar 29, 3:25 AM

	F15385583: D17216.id41410.diff
	Fri, Mar 14, 10:54 PM

	F15384357: D17216.diff
	Fri, Mar 14, 7:37 PM

	Unknown Object (File)
	Feb 21 2025, 3:05 PM

	Unknown Object (File)
	Feb 5 2025, 5:16 AM

	Unknown Object (File)
	Feb 2 2025, 6:38 PM

	Unknown Object (File)
	Jan 31 2025, 7:26 AM

	Unknown Object (File)
	Jan 29 2025, 1:28 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rPdb65f828ee69: Fix $classes not imploding properly in list view

Summary

Fixes the persistent chat hyperlinks showing.

Test Plan

Open persistent chat, no longer see the hyperlinks showing. Close and open chat. Edit room.

Diff Detail

Repository

rP Phabricator

Branch

classes (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15298
Build 20134: Run Core Tests
Build 20133: arc lint + arc unit

Event Timeline

chad created this revision.Jan 17 2017, 10:55 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 17 2017, 10:55 PM

Harbormaster completed remote builds in B15298: Diff 41409.Jan 17 2017, 10:56 PM

epriestley accepted this revision.Jan 17 2017, 11:18 PM

This revision is now accepted and ready to land.Jan 17 2017, 11:18 PM

Closed by commit rPdb65f828ee69: Fix $classes not imploding properly in list view (authored by chad, committed by chad). · Explain WhyJan 17 2017, 11:30 PM

This revision was automatically updated to reflect the committed changes.

I think I over corrected and fixed the wrong line or something here.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUIListItemView.php

2 lines

Diff 41409

View Options

src/view/phui/PHUIListItemView.php

Fix $classes not imploding properly in list viewClosedPublicActions