Straighten out some stacked action removal behaviors
ClosedPublic
Actions

Authored by epriestley on Jan 5 2017, 3:15 AM.

Tags

None

Referenced Files

	F14380517: D17143.id41230.diff
	Sat, Dec 21, 3:59 AM

	F14377152: D17143.diff
	Sat, Dec 21, 1:01 AM

	F14373064: D17143.id41229.diff
	Fri, Dec 20, 8:25 PM

	Unknown Object (File)
	Tue, Dec 17, 7:43 AM

	Unknown Object (File)
	Mon, Dec 16, 5:17 PM

	Unknown Object (File)
	Tue, Dec 10, 3:41 PM

	Unknown Object (File)
	Fri, Dec 6, 2:12 PM

	Unknown Object (File)
	Fri, Dec 6, 12:09 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12065: Can't close actions in Maniphest

Commits

rP4b94ae15e0bc: Straighten out some stacked action removal behaviors

Summary

Fixes T12065. Some of the normal behavior of these actions got juggled when I made "Accept" and "Reject" conflict.

Test Plan

Added "Accept".
Added "Reject", saw it remove "Accept".
Added "Change Projects".
Added "Assign/Claim".
Removed "Assign/Claim".
Removed "Accept".

Diff Detail

Repository

rP Phabricator

Branch

action1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15112
Build 19841: Run Core Tests
Build 19840: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 5 2017, 3:15 AM

chad accepted this revision.Jan 5 2017, 3:16 AM

This revision is now accepted and ready to land.Jan 5 2017, 3:16 AM

Harbormaster completed remote builds in B15112: Diff 41229.Jan 5 2017, 3:16 AM

Closed by commit rP4b94ae15e0bc: Straighten out some stacked action removal behaviors (authored by epriestley, committed by epriestley). · Explain WhyJan 5 2017, 3:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

22 lines

webroot/

rsrc/

js/

application/

transactions/

behavior-comment-actions.js

6 lines

Diff 41229

View Options

resources/celerity/map.php