Page MenuHomePhabricator
Differential D17065

Add EditEngine typeahead
ClosedPublic
Actions

Authored by chad on Dec 16 2016, 5:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 9:42 AM
Unknown Object (File)
Tue, Dec 24, 9:42 AM
Unknown Object (File)
Sun, Dec 22, 1:55 PM
Unknown Object (File)
Sun, Dec 15, 1:20 AM
Unknown Object (File)
Wed, Dec 11, 2:08 AM
Unknown Object (File)
Mon, Dec 9, 5:58 AM
Unknown Object (File)
Mon, Dec 9, 5:57 AM
Unknown Object (File)
Mon, Dec 9, 5:56 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP92db64c1b247: Add EditEngine typeahead
Summary

Allows you to set forms via typeahead

Test Plan

/typeahead/browse/PhabricatorEditEngineDatasource/

Diff Detail

Repository
rP Phabricator
Branch
form-typeahead (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14942
Build 19582: Run Core Tests
Build 19581: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 41053.Dec 16 2016, 5:48 AM
chad retitled this revision from to Add EditEngine typeahead.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 16 2016, 5:48 AM
epriestley accepted this revision.EditedDec 16 2016, 12:01 PM
epriestley edited edge metadata.

Potential issues on D17064 mostly apply here, too, but nothing too critical.

This revision is now accepted and ready to land.Dec 16 2016, 12:01 PM
chad added a comment.Dec 16 2016, 3:11 PM

I just build ngram indexes for them or is there something simpler? I plan to make these more useful in the next pass.

epriestley added a comment.Dec 16 2016, 3:18 PM

ngram indexes are the simplest available approach.

Closed by commit rP92db64c1b247: Add EditEngine typeahead (authored by chad, committed by chad). · Explain WhyDec 16 2016, 4:40 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Dec 17 2016, 5:09 AM

Realized here tonight that builtin forms don't have PHIDs, so the typeahead only works with Custom Forms. Any easy solution?

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
transactions/
typeahead/
39 lines

Diff 41053

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/transactions/typeahead/PhabricatorEditEngineDatasource.php

Loading...
Phabricator · Built by Phacility