Fix a ModularTransactions exception with custom fields that support change details
ClosedPublic
Actions

Authored by epriestley on Dec 14 2016, 1:53 AM.

Details

Reviewers

chad

Commits

rP0c6e03d5aff9: Fix a ModularTransactions exception with custom fields that support change…

Summary

We're throwing here when we actually want to return null so we make it into custom field handling code. See Conpherence.

Test Plan

Found a failing task and re-executed it with bin/worker execute --id <id>; after this change, it didn't fatal.

Diff Detail

Repository

rP Phabricator

Branch

diff11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14901
Build 19518: Run Core Tests
Build 19517: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 41012.Dec 14 2016, 1:53 AM

epriestley retitled this revision from to Fix a ModularTransactions exception with custom fields that support change details.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Dec 14 2016, 1:53 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 14 2016, 1:53 AM

Closed by commit rP0c6e03d5aff9: Fix a ModularTransactions exception with custom fields that support change… (authored by epriestley, committed by epriestley). · Explain WhyDec 14 2016, 2:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorModularTransactionType.php

2 lines

Diff 41012

View Options

src/applications/transactions/storage/PhabricatorModularTransactionType.php

Fix a ModularTransactions exception with custom fields that support change detailsClosedPublicActions