Allows users set an icon (for reuse on upcoming home) for their dashboard based on 16 descriminating choices.
Details
Details
- Reviewers
epriestley - Commits
- rP26127b9c5f7b: Allow Dashboards to set an icon
Create a new dashboard, set new icon. Edit an existing dashboard, set icon.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dashboard-icon (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 14882 Build 19489: Run Core Tests Build 19488: arc lint + arc unit
Event Timeline
Comment Actions
Looked briefly at making this edit engine, but with copying / etc, didn't seem clear. Honestly not sure we need copying?
Comment Actions
Like, remove copies completely (so you have to start with a blank/template dashboard) or keep the operation but just reference all the panels?
I hate copying too and would love to get rid of it.
Maybe the former behavior is fine, especially if we make query panels easier.
Comment Actions
(Actual code seems fine, and I don't think it makes EditEngine/ModularTransactions meaningfully harder to switch to later.)
Comment Actions
I'd like to try to remove copying, but will have to see how easy we can make building/installing dashboards.