Page MenuHomePhabricator
Differential D17041

Rename "DifferentialReviewer" to "DifferentialReviewerProxy"
ClosedPublic
Actions

Authored by epriestley on Dec 13 2016, 6:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 17, 8:30 AM
Unknown Object (File)
Wed, Jun 4, 10:27 PM
Unknown Object (File)
Fri, May 30, 12:51 AM
Unknown Object (File)
Thu, May 29, 8:52 AM
Unknown Object (File)
Thu, May 29, 6:41 AM
Unknown Object (File)
Wed, May 28, 2:47 PM
Unknown Object (File)
Tue, May 27, 6:51 PM
Unknown Object (File)
Apr 28 2025, 1:44 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10967: Move Differential reviewers back to a dedicated database storage table
Commits
rP77fa1ea73835: Rename "DifferentialReviewer" to "DifferentialReviewerProxy"
Summary

Ref T10967. This makes room for a DifferentialReviewer object which can be a real storage table.

Test Plan

Grepped for DifferentialReviewer, browsed Differential.

Diff Detail

Repository
rP Phabricator
Branch
diff4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14881
Build 19487: Run Core Tests
Build 19486: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40992.Dec 13 2016, 6:17 PM
epriestley retitled this revision from to Rename "DifferentialReviewer" to "DifferentialReviewerProxy".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10967: Move Differential reviewers back to a dedicated database storage table.
chad accepted this revision.Dec 13 2016, 6:24 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 6:24 PM
Closed by commit rP77fa1ea73835: Rename "DifferentialReviewer" to "DifferentialReviewerProxy" (authored by epriestley, committed by epriestley). · Explain WhyDec 13 2016, 10:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40992

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialCommentSaveController.php

Loading...
View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
View Options

src/applications/differential/storage/DifferentialReviewer.php

Loading...
View Options

src/applications/differential/storage/DifferentialReviewerProxy.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/differential/view/DifferentialReviewersView.php

Loading...
Phabricator · Built by Phacility