Page MenuHomePhabricator
Differential D17036

Add authorPHID to Dashboard Panels
ClosedPublic
Actions

Authored by chad on Dec 13 2016, 2:59 AM.
Tags
None
Referenced Files
F14727616: D17036.id40988.diff
Sat, Jan 18, 4:40 AM
F14715315: D17036.id40982.diff
Fri, Jan 17, 5:58 PM
F14712560: D17036.id40986.diff
Fri, Jan 17, 3:52 PM
Unknown Object (File)
Wed, Jan 15, 2:58 PM
Unknown Object (File)
Tue, Jan 14, 8:36 PM
Unknown Object (File)
Sat, Jan 4, 9:46 PM
Unknown Object (File)
Tue, Dec 31, 9:00 PM
Unknown Object (File)
Tue, Dec 24, 4:47 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPc03a412d5c4d: Add authorPHID to Dashboard Panels
Summary

Adds authorPHID to panels so we can default to the panels you made.

Test Plan

Run upgrade, visit manage panels, see my panels. Create a new panel. Edit a panel.

Diff Detail

Repository
rP Phabricator
Branch
panel-author (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14871
Build 19468: Run Core Tests
Build 19467: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40981.Dec 13 2016, 2:59 AM
chad retitled this revision from to Add authorPHID to Dashboard Panels.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 13 2016, 2:59 AM
chad updated this revision to Diff 40982.Dec 13 2016, 3:03 AM
  • speeling
epriestley accepted this revision.Dec 13 2016, 11:49 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 11:49 AM
epriestley requested changes to this revision.Dec 13 2016, 12:12 PM
epriestley edited edge metadata.

Oh, actually, I think there's a missing workflow. Does this work?

  • Edit someone else's dashboard.
  • Choose "make a copy".
  • You should become the author of all the copied panels, but I think you won't.
src/applications/dashboard/storage/PhabricatorDashboardPanel.php
37–39

Oh, this probably needs to take a user and reset the authorPHID.

This revision now requires changes to proceed.Dec 13 2016, 12:12 PM
chad updated this revision to Diff 40986.Dec 13 2016, 5:45 PM
chad edited edge metadata.
  • pass user in when copying panel
  • fix query variable for searching dashboards
chad updated this revision to Diff 40987.Dec 13 2016, 5:49 PM
chad edited edge metadata.
  • fix var name
epriestley added inline comments.Dec 13 2016, 5:50 PM
src/applications/dashboard/storage/PhabricatorDashboardPanel.php
40

Should be $user->getPHID()?

chad updated this revision to Diff 40988.Dec 13 2016, 5:53 PM
  • $user->getPHID()
epriestley accepted this revision.Dec 13 2016, 6:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 13 2016, 6:06 PM
Closed by commit rPc03a412d5c4d: Add authorPHID to Dashboard Panels (authored by chad, committed by chad). · Explain WhyDec 13 2016, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40982

View Options

resources/sql/autopatches/20161212.dashboardpanel.01.author.sql

Loading...
View Options

resources/sql/autopatches/20161212.dashboardpanel.02.author.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php

Loading...
View Options

src/applications/dashboard/query/PhabricatorDashboardPanelSearchEngine.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...
Phabricator · Built by Phacility