Page MenuHomePhabricator
Differential D17033

Move timeline anchor targets up to evade a Chrome 55 behavioral change
ClosedPublic
Actions

Authored by epriestley on Dec 12 2016, 6:36 PM.
Tags
None
Referenced Files
F14036072: D17033.id40974.diff
Sun, Nov 10, 8:27 AM
F14032085: D17033.diff
Sat, Nov 9, 12:44 PM
F14013522: D17033.id40974.diff
Sat, Nov 2, 7:31 AM
F14013044: D17033.id.diff
Fri, Nov 1, 11:47 PM
F13997089: D17033.id.diff
Thu, Oct 24, 2:02 AM
F13986656: D17033.diff
Mon, Oct 21, 4:34 AM
F13981189: D17033.id40974.diff
Sat, Oct 19, 2:48 PM
Unknown Object (File)
Oct 8 2024, 1:57 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden
Commits
rP3277e7873211: Move timeline anchor targets up to evade a Chrome 55 behavioral change
Summary

Fixes T11997. This lifts the targets out of the containing overflow: hidden; div so Chrome is willing to target them.

Test Plan

In Chrome, visited direct comment links and ended up in the right place. Clicked comment anchors, saw browser jump around again.

Diff Detail

Repository
rP Phabricator
Branch
anchor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14862
Build 19454: Run Core Tests
Build 19453: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40973.Dec 12 2016, 6:36 PM
epriestley retitled this revision from to Move timeline anchor targets up to evade a Chrome 55 behavioral change.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.
chad accepted this revision.Dec 12 2016, 6:38 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 12 2016, 6:38 PM
Closed by commit rP3277e7873211: Move timeline anchor targets up to evade a Chrome 55 behavioral change (authored by epriestley, committed by epriestley). · Explain WhyDec 12 2016, 6:39 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.Dec 12 2016, 6:46 PM

Revision Contents
Changeset List

PathSize
src/
view/
phui/
18 lines

Diff 40973

View Options

src/view/phui/PHUITimelineEventView.php

Loading...
Phabricator · Built by Phacility