Page MenuHomePhabricator
Differential D17031

Restrict hover styles in action list to only href
ClosedPublic
Actions

Authored by chad on Dec 12 2016, 5:06 PM.
Tags
None
Referenced Files
F14060580: D17031.diff
Mon, Nov 18, 2:15 AM
F14049431: D17031.diff
Thu, Nov 14, 12:56 PM
F14037005: D17031.id40968.diff
Sun, Nov 10, 1:22 PM
F14036530: D17031.diff
Sun, Nov 10, 10:37 AM
F14018944: D17031.diff
Tue, Nov 5, 8:39 PM
F14001060: D17031.id.diff
Fri, Oct 25, 3:49 AM
F13992599: D17031.id40968.diff
Tue, Oct 22, 5:41 PM
F13968557: D17031.diff
Oct 16 2024, 9:54 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPa79e4b786ea3: Restrict hover styles in action list to only href
Summary

We're currently applying these styles to labels, restrict them to only list elements that have an href.

Test Plan

Test a label, an anchor, and a button as an action item.

Diff Detail

Repository
rP Phabricator
Branch
action-view-href (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14857
Build 19446: Run Core Tests
Build 19445: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40968.Dec 12 2016, 5:06 PM
chad retitled this revision from to Restrict hover styles in action list to only href.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 12 2016, 5:06 PM
epriestley accepted this revision.Dec 12 2016, 5:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 12 2016, 5:06 PM
Closed by commit rPa79e4b786ea3: Restrict hover styles in action list to only href (authored by chad, committed by chad). · Explain WhyDec 12 2016, 5:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
layout/
4 lines
webroot/
rsrc/
css/
phui/
4 lines

Diff 40968

View Options

resources/celerity/map.php

Loading...
View Options

src/view/layout/PhabricatorActionView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility