Page MenuHomePhabricator
Differential D17026

Rename "ProfilePanelEditEngine" to "ProfileMenuEditEngine"
ClosedPublic
Actions

Authored by epriestley on Dec 11 2016, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 5:40 PM
Unknown Object (File)
Sun, Dec 8, 8:45 AM
Unknown Object (File)
Fri, Nov 29, 10:17 PM
Unknown Object (File)
Thu, Nov 28, 1:43 AM
Unknown Object (File)
Wed, Nov 20, 8:26 AM
Unknown Object (File)
Nov 16 2024, 11:31 AM
Unknown Object (File)
Nov 12 2024, 10:44 AM
Unknown Object (File)
Nov 8 2024, 3:04 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11957: Add MenuEngine to Home
Commits
rPd6704705a752: Rename "ProfilePanelEditEngine" to "ProfileMenuEditEngine"
Summary

Ref T11957.

Test Plan

Edited profile menus, grepped for renamed symbol.

Diff Detail

Repository
rP Phabricator
Branch
panel2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14843
Build 19425: Run Core Tests
Build 19424: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40954.Dec 11 2016, 5:08 PM
epriestley retitled this revision from to Rename "ProfilePanelEditEngine" to "ProfileMenuEditEngine".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11957: Add MenuEngine to Home.
epriestley added inline comments.Dec 11 2016, 5:09 PM
src/applications/search/editor/PhabricatorProfileMenuEditEngine.php
6

This is safe to change because the edit forms for this engine aren't configurable, so it is currently never saved to the database.

chad accepted this revision.Dec 11 2016, 5:21 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2016, 5:21 PM
Closed by commit rPd6704705a752: Rename "ProfilePanelEditEngine" to "ProfileMenuEditEngine" (authored by epriestley, committed by epriestley). · Explain WhyDec 11 2016, 7:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
search/
editor/
PhabricatorProfileMenuEditEngine.php
PhabricatorProfilePanelEditEngine.php
4 lines
engine/
6 lines

Diff 40954

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/search/editor/PhabricatorProfileMenuEditEngine.php

Loading...
View Options

src/applications/search/editor/PhabricatorProfilePanelEditEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...
Phabricator · Built by Phacility