Page MenuHomePhabricator
Differential D17025

Rename "PanelEngine" to "MenuEngine"
ClosedPublic
Actions

Authored by epriestley on Dec 11 2016, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 18, 12:11 PM
Unknown Object (File)
Sun, Feb 9, 3:00 AM
Unknown Object (File)
Sun, Feb 9, 3:00 AM
Unknown Object (File)
Sun, Feb 9, 2:59 AM
Unknown Object (File)
Wed, Feb 5, 7:55 AM
Unknown Object (File)
Fri, Jan 24, 9:41 PM
Unknown Object (File)
Fri, Jan 24, 6:27 PM
Unknown Object (File)
Fri, Jan 24, 6:27 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11957: Add MenuEngine to Home
Commits
rP923d3d306062: Rename "PanelEngine" to "MenuEngine"
Summary

Ref T11957.

Test Plan

Grepped for "PanelEngine", renamed everything except "PanelEditEngine".

Grepped for these changed symbols:

ispanelengineconfigurable
getprofilepanelengine
setprofilepanelengine
setpanelengine
getpanelengine
PhabricatorProfilePanelEditEngine

Diff Detail

Repository
rP Phabricator
Branch
panel1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14842
Build 19423: Run Core Tests
Build 19422: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40953.Dec 11 2016, 5:03 PM
epriestley retitled this revision from to Rename "PanelEngine" to "MenuEngine".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11957: Add MenuEngine to Home.
chad accepted this revision.Dec 11 2016, 5:20 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 11 2016, 5:20 PM
Closed by commit rP923d3d306062: Rename "PanelEngine" to "MenuEngine" (authored by epriestley, committed by epriestley). · Explain WhyDec 11 2016, 7:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40953

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileManageController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/applications/people/engine/PhabricatorPeopleProfileMenuEngine.php

Loading...
View Options

src/applications/people/engine/PhabricatorPeopleProfilePanelEngine.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectPanelController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectViewController.php

Loading...
View Options

src/applications/project/engine/PhabricatorProjectProfileMenuEngine.php

Loading...
View Options

src/applications/project/engine/PhabricatorProjectProfilePanelEngine.php

Loading...
View Options

src/applications/search/editor/PhabricatorProfilePanelEditEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorProfilePanelEngine.php

Loading...
Phabricator · Built by Phacility