Paths

Table of Contentst

Differential D17023

Fake an outline ring on buttons
ClosedPublic
Actions

Authored by chad on Dec 11 2016, 12:58 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T11990: Outline is invisible on submit buttons

Commits

rPfddd46740064: Fake an outline ring on buttons

Summary

Fixes T11990. Chrome/Ubuntu doesn't respect outline: auto, so this is the only workaround I could fine. Somewhat nicer than stock Chrome.

Test Plan

tab tab tab tab, ubuntu, chrome, windows, safari.

Diff Detail

Repository

rP Phabricator

Branch

glowy-mc-glowface (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14838
Build 19417: Run Core Tests
Build 19416: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40950.Dec 11 2016, 12:58 AM

chad retitled this revision from to Fake an outline ring on buttons.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11990: Outline is invisible on submit buttons.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 11 2016, 12:58 AM

epriestley accepted this revision.Dec 11 2016, 1:16 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 11 2016, 1:16 PM

Closed by commit rPfddd46740064: Fake an outline ring on buttons (authored by chad, committed by chad). · Explain WhyDec 11 2016, 5:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-button.css

11 lines

Diff 40950

View Options

resources/celerity/map.php