Differential D17014

Add a setup check for installation on a burstable instance type
ClosedPublic
Actions

Authored by epriestley on Dec 9 2016, 4:05 PM.

Details

Reviewers

chad

Maniphest Tasks

T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS

Commits

rP9017bb9925e8: Add a setup check for installation on a burstable instance type

Summary

Fixes T11544. Attempt to detect if we're on a tiny, burstable-CPU AWS instance and complain.

Test Plan

Completely faked this locally.
Hit the URI on an EC2 instance to check that it's correct (got back "m3.large", since that was the instance class).

Diff Detail

Repository

rP Phabricator

Branch

setup1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14821
Build 19391: Run Core Tests
Build 19390: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40934.Dec 9 2016, 4:05 PM

epriestley retitled this revision from to Add a setup check for installation on a burstable instance type.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS.

chad accepted this revision.Dec 9 2016, 4:30 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 9 2016, 4:30 PM

Closed by commit rP9017bb9925e8: Add a setup check for installation on a burstable instance type (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2016, 4:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorWebServerSetupCheck.php

45 lines

Diff 40934

View Options

src/applications/config/check/PhabricatorWebServerSetupCheck.php

Add a setup check for installation on a burstable instance typeClosedPublicActions