Page MenuHomePhabricator
Differential D17011

When a custom logo is configured but has a restrictive visibility policy, fall back to the default logo
ClosedPublic
Actions

Authored by epriestley on Dec 9 2016, 12:24 PM.
Tags
None
Referenced Files
F13201831: D17011.id40933.diff
Tue, May 14, 5:12 PM
F13191263: D17011.id40929.diff
Sat, May 11, 6:34 PM
F13185392: D17011.diff
Sat, May 11, 2:52 AM
Unknown Object (File)
Tue, May 7, 5:18 AM
Unknown Object (File)
Fri, May 3, 2:39 AM
Unknown Object (File)
Mon, Apr 29, 2:12 PM
Unknown Object (File)
Wed, Apr 24, 10:16 PM
Unknown Object (File)
Sun, Apr 21, 6:12 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site
Commits
rPcde37acb4bd4: When a custom logo is configured but has a restrictive visibility policy, fall…
Summary

Fixes T11982. Currently, configuring a custom logo and then setting the policy restrictively locks off the whole install.

Test Plan
  • Configured ui.logo.
  • Searched for the file PHID in global search to find the underlying file.
  • Set the policy to something restrictive ("only me").
  • Purged cache (bin/cache purge --purge-all).
  • Restarted webserver to nuke APC.
  • Loaded a page as a different user.
  • Before change: policy exception while trying to load the logo.
  • After change: fallback to default logo.
  • Loaded page as user who can see the logo, got custom logo.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40929.Dec 9 2016, 12:24 PM
epriestley retitled this revision from to When a custom logo is configured but has a restrictive visibility policy, fall back to the default logo.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.
epriestley mentioned this in T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.Dec 9 2016, 1:01 PM
chad accepted this revision.Dec 9 2016, 3:20 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 9 2016, 3:20 PM
Closed by commit rPcde37acb4bd4: When a custom logo is configured but has a restrictive visibility policy, fall… (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2016, 3:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
page/
menu/
17 lines

Diff 40933

View Options

src/view/page/menu/PhabricatorMainMenuView.php

Loading...
Phabricator · Built by Phacility