Differential D17010

In Remarkup, render archived Herald rules with strikethrough for consistency
ClosedPublic
Actions

Authored by epriestley on Dec 8 2016, 7:25 PM.

Details

Reviewers

chad

Maniphest Tasks

T11969: Render archived Herald rules as strike-through when mentioning them ("Hxxx") in a Maniphest task

Commits

rPbe4f66a5a329: In Remarkup, render archived Herald rules with strikethrough for consistency

Summary

Fixes T11969.

Test Plan

Screen Shot 2016-12-08 at 11.24.25 AM.png (253×386 px, 23 KB)

Diff Detail

Repository

rP Phabricator

Branch

hrule1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14812
Build 19375: Run Core Tests
Build 19374: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40925.Dec 8 2016, 7:25 PM

epriestley retitled this revision from to In Remarkup, render archived Herald rules with strikethrough for consistency.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11969: Render archived Herald rules as strike-through when mentioning them ("Hxxx") in a Maniphest task.

chad accepted this revision.Dec 8 2016, 8:35 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 8 2016, 8:35 PM

Closed by commit rPbe4f66a5a329: In Remarkup, render archived Herald rules with strikethrough for consistency (authored by epriestley, committed by epriestley). · Explain WhyDec 8 2016, 8:37 PM

This revision was automatically updated to reflect the committed changes.

epriestley edited the test plan for this revision. (Show Details)Dec 8 2016, 8:39 PM

epriestley edited edge metadata.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

phid/

HeraldRulePHIDType.php

4 lines

Diff 40925

View Options

src/applications/herald/phid/HeraldRulePHIDType.php

In Remarkup, render archived Herald rules with strikethrough for consistencyClosedPublicActions