Page MenuHomePhabricator
Differential D17005

Fix some form layout issues in settings
ClosedPublic
Actions

Authored by chad on Dec 7 2016, 5:14 AM.
Tags
None
Referenced Files
F14403143: D17005.diff
Mon, Dec 23, 1:44 AM
Unknown Object (File)
Wed, Dec 18, 12:34 PM
Unknown Object (File)
Thu, Dec 12, 1:51 AM
Unknown Object (File)
Wed, Dec 11, 11:46 PM
Unknown Object (File)
Sat, Dec 7, 7:24 PM
Unknown Object (File)
Sat, Dec 7, 5:06 PM
Unknown Object (File)
Mon, Dec 2, 4:18 PM
Unknown Object (File)
Sat, Nov 30, 2:33 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP8bbed7974d62: Fix some form layout issues in settings
Summary

Form inputs with just text or certain selects had extra space. This uses better text centering.

Test Plan

Review forms on all Settings pages, Custom Policy, Herald.

Diff Detail

Repository
rP Phabricator
Branch
form-nudge (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14800
Build 19356: Run Core Tests
Build 19355: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40912.Dec 7 2016, 5:14 AM
chad retitled this revision from to Fix some form layout issues in settings.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 7 2016, 5:14 AM
chad updated this revision to Diff 40913.Dec 7 2016, 5:24 AM
  • minor other spacings
epriestley accepted this revision.Dec 7 2016, 8:53 PM
epriestley edited edge metadata.

By the way, I really like that PHUIInfoView tweak you did a while back. Error messages are far more pleasant now.

This revision is now accepted and ready to land.Dec 7 2016, 8:53 PM
Closed by commit rP8bbed7974d62: Fix some form layout issues in settings (authored by chad, committed by chad). · Explain WhyDec 7 2016, 9:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
webroot/
rsrc/
css/
phui/
2 lines
10 lines

Diff 40913

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-comment-form.css

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
Phabricator · Built by Phacility